[wallet] return correct error code from resendwallettransaction #11002

1. 
   jnewbery commented at 7:53 PM on August 7, 2017: member

   New code in #10995 uses RPC_INVALID_REQUEST. According to the comment in rpc/protocol.h:

   // RPC_INVALID_REQUEST is internally mapped to HTTP_BAD_REQUEST (400).
   // It should not be used for application-layer errors.
   

   Change the returned error code to RPC_WALLET_ERROR

   #11000 will need to be updated to test for the correct error code.

2. [wallet] return correct error code from resendwallettransaction 055d95f842
3. jnewbery cross-referenced this on Aug 7, 2017 from issue Fix resendwallettransactions assert failure if -walletbroadcast=0 by TheBlueMatt
4. MarcoFalke added this to the milestone 0.15.0 on Aug 7, 2017
5. MarcoFalke added the label RPC/REST/ZMQ on Aug 7, 2017
6. 
   MarcoFalke commented at 8:19 PM on August 7, 2017: member

   utACK 055d95f842e3659c41ad55101df8dce4865cd68f

7. promag cross-referenced this on Aug 7, 2017 from issue test: Add resendwallettransactions functional tests by promag
8. 
   promag commented at 9:26 PM on August 7, 2017: member

   Tested ACK 055d95f.

9. 
   laanwj commented at 9:41 AM on August 8, 2017: member

   Good catch. utACK.

10. laanwj merged this on Aug 8, 2017
11. laanwj closed this on Aug 8, 2017

    ---

12. laanwj referenced this in commit 4268426b45 on Aug 8, 2017
13. UdjinM6 referenced this in commit da63a2deac on Aug 4, 2019
14. PastaPastaPasta referenced this in commit f1f9e5dfb5 on Aug 5, 2019
15. PastaPastaPasta referenced this in commit 44dc84e69a on Aug 6, 2019
16. PastaPastaPasta referenced this in commit b0aef55115 on Aug 6, 2019
17. barrystyle referenced this in commit 0b532c71fb on Jan 22, 2020
18. bitcoin locked this on Sep 8, 2021

Milestone
0.15.0