[Qt] import* rescans are not abortable and can confuse users #10992

issue achow101 opened this issue on August 5, 2017
  1. achow101 commented at 8:45 AM on August 5, 2017: member

    When importing something with any of the import* commands from the qt debug window console, a progress bar appears which is uncancelable and unminimizable. Furthermore, trying to close the progress bar window simply makes it disappear, and then shortly appear again. This behavior is clearly seen in the gif below.

    peek 2017-08-05 01-39

    Rescanning also completely locks up the GUI and nothing else can be done.

    Since there is an abortrescan RPC command, there should be some way to abort a rescan now through the progress bar dialog that appears, either with an additional button, or by clicking the X to close it.

  2. achow101 cross-referenced this on Aug 7, 2017 from issue Drop upgrade-cancel callback registration for a generic "cancelable" by TheBlueMatt
  3. jonasschnelli added the label GUI on Aug 8, 2017
  4. jonasschnelli commented at 8:18 AM on August 8, 2017: contributor

    Agree that one should be able to abort rescans. The fix shouldn't be to hard. The progress dialog (QProgressDialog / WalletView::showProgress) could have the optional cancel button. The cancel button then could eventually directly call AbortRescan(); or through a callback.

    Rescan locks cs_main and cs_wallet. Avoiding the GUI locks will be harder (probably doable with @ryanofsky #10973).

  5. juestr commented at 11:13 PM on October 31, 2017: none

    I just tried to bitcoin-cli abortrescan a rescan caused by a cli importprivkey, and it hangs too. Maybe this is not just a GUI problem (0.15.0.1).

  6. achow101 commented at 7:02 PM on June 29, 2018: member

    Fixed by #11200

  7. achow101 closed this on Jun 29, 2018

  8. unknown cross-referenced this on Sep 7, 2019 from issue [QT] Startup Rescan: Progress Bar by ghost
  9. bitcoin locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:54 UTC