Without this change, after building bitcoin master and testing it, I see the following untracked files:
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
(use "git add <file>..." to include in what will be committed)
qa/
src/test/buildenv.py
src/wallet.backup
I've tried to keep the .gitignore lines in the appropriate sections of the file.
Concept ACK
97 | @@ -97,9 +98,11 @@ total.coverage/ 98 | coverage_percent.txt 99 | 100 | #build tests 101 | +qa/
qa/ should no longer be created in current master. If this is still the case, we should rather find the source why this was created then just ignoring it.
I haven't seen any instances of it being created in new trees, so most probably if you have this, it's a remainder from an old build.
48 | @@ -49,6 +49,7 @@ src/qt/test/moc*.cpp 49 | .libs 50 | .*.swp 51 | *.*~* 52 | +*.backup
I guess this would not hurt, though I think we should cleanup the backup file (unlink them) in wallet_test.cpp.
Not only that, but we shouldn't be creating a wallet.backup file in the src directory at all. It should go in the temporary directory created for the other test files.
Sounds like a really bad thing now, someone could confuse it for a real wallet backup, for one.
Thanks for noticing @eklitzke.
Concept ACK.
@eklitzke Are you still working on this?
It looks like I get a clean environment when building on master, including when running the test suite. Previously I had built Bitcoin from a release tag. For this reason, I'm closing the PR.