bitcoin-qt core dumps when bitcoin(d/-qt) is already running #10815

1. 
   morcos commented at 2:52 PM on July 13, 2017: member

   On master at 7666250

   It's expected to just exit cleanly with an error message that it can't obtain a lock on the data directory. Instead it shows that error message and then when you click it away it core dumps.

   This doesn't happen with bitcoind.

   This also results in losing RPC credentials to the running bitcoin(d/-qt)

2. laanwj added this to the milestone 0.15.0 on Jul 13, 2017
3. 
   laanwj commented at 6:56 PM on July 13, 2017: member

   This problem happens because Shutdown() is called, even though the data directory was not locked.

   Most easily reproducible in the GUI, though it's also possible to happen with bitcoind in a rare race condition (if the check in AppInitSanityChecks succeeds, but the lock can't actually be grabbed in AppInitSanityChecks and that exits with false, it will fall through and call Shutdown).

4. laanwj cross-referenced this on Jul 13, 2017 from issue init: Keep track of whether data directory locked, don't cleanup if not by laanwj
5. laanwj added the label GUI on Jul 14, 2017
6. laanwj referenced this in commit ceec6cb45e on Jul 15, 2017
7. laanwj cross-referenced this on Jul 15, 2017 from issue init: Factor out AppInitLockDataDirectory and fix startup core dump issue by laanwj
8. laanwj referenced this in commit dba485d651 on Jul 17, 2017
9. laanwj referenced this in commit 89bb0365b9 on Jul 17, 2017
10. morcos closed this on Jul 17, 2017

    ---

11. fametrano referenced this in commit cbf5ba4603 on Aug 4, 2017
12. JeremyRubin referenced this in commit 0bb52fb5e4 on Aug 9, 2017
13. HashUnlimited referenced this in commit 9e6a1ead63 on Mar 9, 2018
14. PastaPastaPasta referenced this in commit 6fb74ead60 on Aug 2, 2019
15. PastaPastaPasta referenced this in commit 2d96901cc7 on Aug 6, 2019
16. barrystyle referenced this in commit 29f1a577ea on Jan 22, 2020
17. bitcoin locked this on Sep 8, 2021

Contributors

morcoslaanwj

Milestone
0.15.0