Fix bumpfee rpc "errors" return value #10450

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/berr changing 2 files +2 −1

ryanofsky commented at 8:33 PM on May 24, 2017: contributor

No description provided.
Fix bumpfee rpc "errors" return value 1b6602fbe6
ryanofsky force-pushed on May 24, 2017
ryanofsky cross-referenced this on May 24, 2017 from issue should push_back/pushKV methods throw for wrong object types? by ryanofsky
fanquake added the label RPC/REST/ZMQ on May 24, 2017
fanquake added the label Wallet on May 24, 2017
sdaftuar commented at 3:39 PM on May 25, 2017: member

utACK
jonasschnelli commented at 6:26 PM on May 25, 2017: contributor

utACK 1b6602fbe66c0205acd4a33b9183080ec500fc72 I guess this is a tiny API change and maybe deserves a short mentioning in the release notes?
ryanofsky commented at 6:37 PM on May 25, 2017: contributor

I guess this is a tiny API change and maybe deserves a short mentioning in the release notes?

It appears the bug was introduced after the last release (in https://github.com/bitcoin/bitcoin/commit/0337a39d31603eb2c723a560410357f186763dc2#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3093), so I don't think the release notes need to be updated.
jonasschnelli commented at 6:50 PM on May 25, 2017: contributor

Oh! I see, this is an refactoring-bug fix. Sorry for the slouchiness and this certainly doesn't require to be in the RN then.
laanwj commented at 8:48 AM on June 1, 2017: member

utACK 1b6602f
laanwj merged this on Jun 1, 2017
laanwj closed this on Jun 1, 2017
laanwj referenced this in commit ef2d062c9f on Jun 1, 2017
bitcoin locked this on Sep 8, 2021

Contributors

Labels