streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this. This problem does not manifest in practice (yet), it seems.
Discovered by @theuni.
Fix some empty vector references #10250
pull sipa wants to merge 1 commits into bitcoin:master from sipa:nonnullref changing 1 files +6 −2-
sipa commented at 1:01 PM on April 21, 2017: member
-
f478d98fe4
Fix some empty vector references
streams.h has some methods that can be tricked into dereferencing null pointers or end() iterators. Fix this.
- sipa cross-referenced this on Apr 21, 2017 from issue Switch chainstate db and cache to per-txout model by sipa
-
laanwj commented at 1:50 PM on April 21, 2017: member
- laanwj added the label Utils and libraries on Apr 21, 2017
-
theuni commented at 2:01 PM on April 21, 2017: member
utACK f478d98fe49d3c0c0f2c79b3f8d9dbfc1aafd407
-
paveljanik commented at 2:02 PM on April 21, 2017: contributor
utACK f478d98
- laanwj merged this on Apr 21, 2017
- laanwj closed this on Apr 21, 2017
- laanwj referenced this in commit 1428f3030d on Apr 21, 2017
-
jtimon commented at 7:53 PM on April 24, 2017: contributor
post-merge utACK f478d98fe49d3c0c0f2c79b3f8d9dbfc1aafd407
- theuni cross-referenced this on May 8, 2017 from issue Rewrite addrdb with less duplication using CHashVerifier by sipa
- luke-jr referenced this in commit dbfb1f3540 on Jun 3, 2017
- luke-jr referenced this in commit 2b1608b243 on Jun 3, 2017
- luke-jr referenced this in commit bc516945d3 on Jun 3, 2017
- luke-jr referenced this in commit ef924c53d9 on Jun 5, 2017
- luke-jr referenced this in commit 69fda1bfd0 on Jun 5, 2017
- luke-jr referenced this in commit e23cef0c94 on Jun 5, 2017
- sipa deleted the branch on Jun 23, 2017
- nomnombtc referenced this in commit bd52b4d922 on Jul 17, 2017
- ptschip cross-referenced this on Oct 3, 2017 from issue dbcache phase 3 enhancements by ptschip
- codablock referenced this in commit 6cf97b5ba5 on Oct 31, 2017
- codablock referenced this in commit 8ed6722196 on Oct 31, 2017
- codablock cross-referenced this on Oct 31, 2017 from issue Backport bitcoin perutxo by codablock
- UdjinM6 referenced this in commit b22c2b23b2 on Nov 8, 2017
- bitcartel cross-referenced this on Apr 17, 2018 from issue Closes #3182 - Least Authority Issue D by bitcartel
- zkbot referenced this in commit 702a495a01 on Apr 19, 2018
- zkbot referenced this in commit 30b31ea5f6 on Apr 21, 2018
- zkbot referenced this in commit c62365186c on Apr 30, 2018
- zkbot referenced this in commit 2d1a3cf8f5 on May 3, 2018
- random-zebra cross-referenced this on Aug 9, 2020 from issue [Core] Use unordered_map for CCoinsMap and fix empty vectors in streams by random-zebra
- random-zebra referenced this in commit afafd7f6a9 on Aug 12, 2020
- bitcoin locked this on Sep 8, 2021
