[trivial] Fixed -Wshadow warnings #10009

pull tjps wants to merge 1 commits into bitcoin:master from tjps:tjps_shadowing changing 3 files +23 −25

tjps commented at 8:11 AM on March 16, 2017: contributor

No description provided.
[trivial] Fixed -Wshadow warnings 3df45c6748
fanquake added the label Refactoring on Mar 16, 2017
tjps renamed this:
~~[trivial] Fixing -Wshadow warnings~~
[trivial] Fixed -Wshadow warnings
on Mar 16, 2017

in src/test/checkqueue_tests.cpp:None in 3df45c6748

  95 | @@ -96,7 +96,7 @@ struct MemoryCheck {
  96 |      };
  97 |      ~MemoryCheck(){
  98 |          fake_allocated_memory -= b;
  99 | -    
 100 | +

practicalswift commented at 9:26 AM on March 16, 2017:

Intentional blank line? :-)

in src/util.h:None in 3df45c6748

  93 | @@ -94,9 +94,9 @@ template<typename... Args> std::string FormatStringFromLogArgs(const char *fmt,
  94 |  } while(0)
  95 |  
  96 |  template<typename... Args>
  97 | -bool error(const char* fmt, const Args&... args)
  98 | +bool error(const char* fmt, Args... args)

laanwj commented at 10:16 AM on March 16, 2017:

Not sure what you're doing here but I doubt it is required to "Fix Wshadow".

laanwj commented at 10:17 AM on March 16, 2017: member

Also may be duplicate of #9911.
laanwj cross-referenced this on Mar 16, 2017 from issue util: rename variable to avoid shadowing by prusnak
laanwj commented at 5:37 PM on March 16, 2017: member

Closing in favor of #10010 which is cleaner and more targeted.
laanwj closed this on Mar 16, 2017
tjps deleted the branch on May 13, 2017
laanwj cross-referenced this on Feb 10, 2019 from issue build: Disallow shadowing variables via -isystem, -Wshadow by Empact
bitcoin locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#9911 Wshadow: various gcc fixes #10010 util: rename variable to avoid shadowing #15377 build: Disallow shadowing variables via -isystem, -Wshadow