BIP 32: Test vectors for leading zeros #497

pull iancoleman wants to merge 2 commits into bitcoin:master from iancoleman:BIP32-test-vectors changing 1 files +13 −0

iancoleman commented at 12:47 AM on February 24, 2017: contributor

These additional test vectors will ensure all future implementations are compliant with bip32.

See https://github.com/iancoleman/bip39/issues/58 and https://github.com/bitpay/bitcore-lib/issues/47

Possibly these test vectors may be useful also:

bitcoinjs-lib test for this issue

bitcore-lib test for this issue (pending merge)

BIP 32: Test vectors for leading zeros

These additional test vectors will ensure all future implementations are
interoperable.
See https://github.com/iancoleman/bip39/issues/58
and https://github.com/bitpay/bitcore-lib/issues/47

6f94288741

sipa commented at 2:01 AM on February 24, 2017: member

ACK.

I've verified these test vector myself by implementing them in Bitcoin Core's unit test framework.

Thanks for figuring out the cause of the divergence between clients.
Mediawiki format used for external links 11b0fa37be
schildbach referenced this in commit 63674f8def on Feb 25, 2017
schildbach referenced this in commit af40d03867 on Feb 25, 2017
schildbach commented at 11:51 AM on February 25, 2017: contributor

ACK. I just added this test vector to bitcoinj (https://github.com/bitcoinj/bitcoinj/pull/1342).
braydonf referenced this in commit 57b3d95169 on Mar 1, 2017
braydonf commented at 8:36 AM on March 1, 2017: none

ACK. Also added in https://github.com/bitpay/bitcore-lib/pull/97
luke-jr merged this on Mar 6, 2017
luke-jr closed this on Mar 6, 2017
luke-jr added the label Proposed BIP modification on Mar 6, 2017
schildbach referenced this in commit ce07ceabc4 on Mar 6, 2017
schildbach referenced this in commit 5e2e761d72 on Aug 24, 2017

Contributors

Labels

Proposed BIP modification