bip-0375/deps/dleq.py copied dleq_* functions from bip-0374/reference.py and could go out of sync (#2262, #2304). Replace with a loader so the validator uses bip-0374/reference.py.
To run the tests:
python bip-0375/test_runner.py
bip375: import DLEQ from BIP-374 instead of vendoring #2309
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:2026-09-bip375-import-DLEQ-from-BIP374-instead-of-vendoring changing 2 files +24 −80-
jonatack commented at 6:37 PM on September 25, 2026: member
-
jonatack commented at 8:00 PM on September 25, 2026: member
cc BIP authors @andrewtoth, @achow101, @josibake for feedback
-
503119db2c
bip375: import DLEQ from BIP-374 instead of vendoring
bip-0375/deps/dleq.py was a copy of bip-0374/reference.py and could go out of sync. Replace the copy with a loader so the validator always uses the current BIP-374 reference.py.
- jonatack force-pushed on Sep 27, 2026
-
-
macgyver13 commented at 9:01 PM on September 29, 2026: contributor
tACK 503119d
-
fametrano commented at 10:08 AM on October 9, 2026: contributor
I suggest also dropping
bip-0375/deps/secp256k1labin this PR, with its README entry, and pointing its path intest_runner.pytobip-0374/secp256k1lab/src. I tried this locally and the 43 tests pass. The path change is needed: with the copy dropped and the path unchanged, importingvalidator.inputsbeforedeps.dleqfails withModuleNotFoundError: No module named 'secp256k1lab'.At 503119d that copy is no longer used.
deps/dleq.pyloadsbip-0374/reference.py, which putsbip-0374/secp256k1lab/srcat the front ofsys.path. This happens before the validator's firstsecp256k1labimport. So the validator already runs on BIP-374's copy, aspython3 -v bip-0375/test_runner.pyshows. The tests pass either way because the two copies are identical today. If they drift apart, no test will notice, and the README will still list the unused copy as a dependency.
