BIP155: mention IPv4-in-IPv6 range MUST NOT be sent within IPV6 #2234

There was a discrepancy between Bitcoin Core and btcd - that I noticed with bitcoinfuzz - about the rejection of IPv4-in-IPv6 when parsing an addrv2 message. btcd ended up implemented the same behavior while it raised a discussion about this not being mentioned in the BIP.

Rejecting this kind of addresses is important for canonical encoding. The whole point of this BIP is having exactly one representation for each network. Besided that, there are other reasons such as reachability accounting, defense against evasion/bypassing address‑type policy, etc.

That said, this PR changes BIP155 to document the behavior where IPv4 addresses embedded in IPv6 should be rejected.

cc @kcalvinalvin

ACK, good and correct clarification here, consistent with the behavior of BIP155's implementation in Bitcoin Core.

cc BIP author @laanwj for feedback or sign-off

ACK 8a4ed72e28004166608e2c461f53d8e555f93763 This is the correct interpretation according to the original idea. IPv6 address records should only be used for sending actual routable IPv6 addresses, not embedded addresses of other types. Those should get their own type id. In the case of IPv4, that already exists, of course.