BIP-0014: MAX_SUBVERSION_LENGTH #196

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:patch-1 changing 1 files +2 −0
  1. maflcko commented at 8:33 AM on September 12, 2015: member

    I don't know if this should be mentioned in the bip because it may change at some point in the future... Yet, changing it may cause a fork of the network (extremely unlikely but possible).

  2. maflcko renamed this:
    MAX_SUBVERSION_LENGTH
    BIP-0014: MAX_SUBVERSION_LENGTH
    on Sep 12, 2015
  3. in bip-0014.mediawiki:None in 1e4ef3de14 outdated 
      83 | @@ -84,6 +84,8 @@ They should not be misused beyond what is specified in this section.
  84 |  * : specifies the implementation version of the particular stack
  85 |  * ( and ) delimits a comment which optionally separates data using ;
  86 |  
  87 | +The total lenght of the user agent string after appending the optional comments must not exceed 256 bytes.
    luke-jr commented at 6:16 PM on September 19, 2015:

    length*

  4. luke-jr commented at 6:16 PM on September 19, 2015: member

    This shouldn't cause a fork of the network...

  5. maflcko commented at 7:40 AM on September 20, 2015: member

    Imagine I released bitcoin-xxl with twice the MAX_SUBVERSION_LENGTH == 512. The UA string keeps growing over time and reaches maybe 300 bytes some time. Now it's impossible to connect bitcoin-xxl nodes with bitcoin-core 0.11 nodes, potentially splitting the network?

  6. luke-jr commented at 7:50 AM on September 20, 2015: member

    Your XXL node will talk to old/non-spammy XXL nodes which will talk to Core nodes, so no big deal.

  7. MAX_SUBVERSION_LENGTH
    MAX_SUBVERSION_LENGTH = 256
    b3d584a6fd
  8. maflcko commented at 4:42 PM on September 26, 2015: member

    Maybe it's better to just "recommend" the implementation bitcoin-core does/did and link to the PRs...

    Also, ping @luke-jr Could you please enable the GitHub issue tracker for this repo?

  9. luke-jr commented at 1:54 AM on October 2, 2015: member

    @MarcoFalke Discussion of BIPs should be on the bitcoin-dev mailing list, not GitHub. @genjix @phantomcircuit May I close this unmerged?

  10. pstratem commented at 1:56 AM on October 2, 2015: none

    @luke-jr yes

  11. luke-jr closed this on Oct 2, 2015
  12. maflcko deleted the branch on Oct 8, 2015
  13. real-or-random referenced this in commit f71b5cbb5c on Mar 12, 2020
Contributors
maflckoluke-jrpstratem
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-19 06:50 UTC