Wallet Labels Export Format #1383

pull craigraw wants to merge 12 commits into bitcoin:master from craigraw:wallet-labels changing 1 files +131 −0

craigraw commented at 10:02 AM on October 17, 2022: contributor

This was first proposed on the mailing list on Aug 24 as a common format for the export and import of wallet labels.

Following discussion there, on this bitcointalk post and via private channels with other wallet developers, the original proposal was simplified, and changed to use JSON instead of CSV. The revised proposal has been well received, and I believe is ready for consideration as a BIP.

Link: https://github.com/craigraw/bips/blob/master/bip-wallet-labels.mediawiki
initial commit c497b95372
fix formatting d81452fbae
add importing section 80c44a97a9
clarify csv preference 71243cbf07
tabs to spaces e09061aeb2
add rationale and references, require that rfc4180 is followed 1689d24e88
fix reference links a8261e3c39
show reference links as list 6bf0390b53
use self describing json lines format instead of csv 7f0024405c
Merge branch 'bitcoin:master' into wallet-labels da09065f39
abdul-hannan1 commented at 1:32 AM on October 27, 2022: none

I have address bsc
manda2020panda approved
moneymanolis approved
moneymanolis commented at 5:57 PM on December 15, 2022: none

What's blocking the merge of this?
k9ert approved
kallewoof added the label New BIP on Jan 4, 2023

in bip-wallet-labels.mediawiki:82 in da09065f39 outdated

  77 | +| Address in base58 or bech32 format
  78 | +| <tt>bc1q34aq5drpuwy3wgl9lhup9892qp6svr8ldzyy7c</tt>
  79 | +|-
  80 | +| <tt>pubkey</tt>
  81 | +| 32 or 33 byte public key in hexadecimal format
  82 | +| <tt>0283409659355b6d1cc3c32decd5d561abaac86c37a353b52895a5e6c196d6f448</tt>

luke-jr commented at 4:25 PM on January 16, 2023:

What about 65-byte pubkeys?

craigraw commented at 5:06 PM on January 16, 2023:

Good point, added.

luke-jr commented at 4:33 PM on January 16, 2023: member

Assigned BIP 329
add bip number and accommodate 65 byte pubkeys d6fb6424ae
craigraw commented at 5:08 PM on January 16, 2023: contributor

Edited to assign BIP number 329. Pinging @kallewoof
fix comments uri 32ba2ffe6f
kallewoof merged this on Jan 16, 2023
kallewoof closed this on Jan 16, 2023
dipunm commented at 11:07 AM on January 17, 2023: none

I get that this is closed, but am new to commenting on bips so I'll add my comment here.

An importing wallet may ignore records it does not store, and truncate labels if necessary.

I think adding truncation as a standard is dangerous. Context can be lost, especially if context was at the end. Also different apps may have further restrictions such as character limitations (no emoticon support or Chinese character support)

Is it not more appropriate to warn that care should be taken if truncating or modifying the label and/or a warning should be given if any modifications will be made. UI is up to the app.

Something like that?

Contributors

Labels