With the addition of the MUST_SIGNAL phase, signalling during LOCKED_IN is no longer needed for activation coordination, so drop it.
BIP8: Make signalling during LOCKED_IN recommended rather than mandatory #1020
pull ajtowns wants to merge 1 commits into bitcoin:master from ajtowns:202010-bip8-lockedin-rec changing 1 files +5 −9-
ajtowns commented at 8:26 AM on October 17, 2020: contributor
-
BIP8: Make signalling during LOCKED_IN recommended rather than mandatory 9a119ce46a
-
ajtowns commented at 9:17 AM on October 17, 2020: contributor
At present, the only time anyone has to potentially immediately update their consensus rules is if the last block in a STARTED period pushes signalling over the threshold, at which point the next block has to immediately signal or is invalid. There's grace periods for everything else -- enforcing the rules has the 2016 blocks of LOCKED_IN between knowing it's coming and it actually happening; and the first block of MUST_SIGNAL (hopefully) has a few months of grace between everyone deciding to set lockinontimeout=true and timeoutheight actually arriving.
- luke-jr added the label Proposed BIP modification on Oct 19, 2020
-
jonasnick commented at 8:26 PM on October 26, 2020: contributor
ACK this seems to be a remnant from before MUST_SIGNAL and there's no reason to not have a grace period
-
michaelfolkson commented at 2:09 PM on January 30, 2021: none
ACK. LOCKED_IN is an end state on the happy path. Once we reach this state there are no requirements in terms of signaling. Continued signaling is a nice to have but has no impact on the path taken or the end result.
-
benthecarman commented at 3:56 PM on February 2, 2021: contributor
ACK this makes more sense
- luke-jr merged this on Feb 2, 2021
- luke-jr closed this on Feb 2, 2021
-
achow101 commented at 7:52 PM on February 2, 2021: member
ACK 9a119ce46af235a7711c137f8683e5c499cca026
- ProofOfKeags approved
-
ProofOfKeags commented at 7:52 PM on February 2, 2021: contributor
ACK
-
lucasmoten commented at 7:53 PM on February 2, 2021: none
ACK
-
AbelLykens commented at 7:53 PM on February 2, 2021: none
ACK
-
wangchun commented at 7:53 PM on February 2, 2021: contributor
ACK
-
AlejandroDeLaTorre commented at 7:53 PM on February 2, 2021: none
ACK
-
setpill commented at 7:53 PM on February 2, 2021: none
-
darosior commented at 7:54 PM on February 2, 2021: member
ACK 9a119ce46af235a7711c137f8683e5c499cca026
-
kaloudis commented at 11:41 PM on February 2, 2021: none
